databendlabs / openraft / 20678346716

88%

Build Type

push

github

Committed by drmingdrmer

Commit Message

change: replace `RaftLogStorage::truncate()` with `truncate_after()`

Replace the `truncate()` method with `truncate_after()` in the `RaftLogStorage`
trait to provide clearer log truncation semantics. The new method takes
`Option<LogId>` and keeps logs up to and including the given log id.

Changes:
- Replace `truncate()` with `truncate_after()` in `RaftLogStorage` trait
- Update all store implementations to use the new method
- Update internal raft_core to use `truncate_after()`
- Add `delete_logs_after_5` test for mid-log truncation coverage

Upgrade tip:

If you implement `RaftLogStorage`, replace your `truncate()` implementation
with `truncate_after()`. The key semantic difference:

- `truncate(log_id)`: deleted logs from `log_id.index()` onwards (inclusive)
- `truncate_after(last_log_id)`: deletes logs after `last_log_id` (exclusive)

Update your implementation:
```rust
// Before:
async fn truncate(&mut self, log_id: LogId) -> Result<(), io::Error> {
    delete_from(log_id.index()..);
}

// After:
async fn truncate_after(&mut self, last_log_id: Option<LogId>) -> Result<(), io::Error> {
    let start = last_log_id.map(|id| id.index() + 1).unwrap_or(0);
    delete_from(start..);
}
```

Run Details

72 of 72 new or added lines in 8 files covered. (100.0%)

6 existing lines in 2 files now uncovered.

15574 of 17792 relevant lines covered (87.53%)

160109.77 hits per line