google / alioth / 20670092116

26%

push

github

fix(vu): serve only one vmm at one time

A VirtIO device generally needs exclusive access to specific resources
on the host. Creating multiple devices from the same config to serve
multiple VMs simultaneously could lead to resource contention.

Especially, commit de79b5f95853 made device creation ahead of connection
acceptance, and failed virtio-net devices, because when 1 virtio-net
device is running, another virtio-net device is created, and the latter
opens the same tap again, interfering with the first device's IO.

Fixes: de79b5f95853 ("fix(vu): create devices before accepting connections")
Signed-off-by: Changyuan Lyu <changyuanl@google.com>

425 of 1144 branches covered (37.15%)

Branch coverage included in aggregate %.

0 of 1 new or added line in 1 file covered. (0.0%)

3587 of 13993 relevant lines covered (25.63%)

23.16 hits per line