StoneCypher / circular_buffer_js / 20650934384

100%

push

github

Fix three bugs: pop() return type, fill() cursor reset, and comment errors

This commit addresses three bugs found in the circular buffer implementation:

1. Type Safety Bug - pop() return type (HIGH severity)
   - Changed pop() return type from 'T | undefined' to 'T'
   - The method never returns undefined; it either returns T or throws RangeError
   - Previous type signature was misleading and could cause incorrect null checks
   - Affects: src/ts/circular_buffer.ts:708

2. Consistency Bug - fill() missing cursor reset (MEDIUM severity)
   - Added 'this._cursor = 0' to fill() method
   - Now consistent with similar buffer-reorganizing methods (reverse, every, some)
   - Previously left internal rotation state unnormalized after filling
   - Affects: src/ts/circular_buffer.ts:501

3. Documentation Bug - copy-paste comment errors (LOW severity)
   - Fixed comment in some() that incorrectly said "every can mutate"
   - Fixed typo "_this.offset" → "this._offset"
   - Comments were copied from every() method and not updated
   - Affects: src/ts/circular_buffer.ts:611, 616

All tests pass (84/84) with 100% coverage maintained.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>

43 of 43 branches covered (100.0%)

Branch coverage included in aggregate %.

1 of 1 new or added line in 1 file covered. (100.0%)

110 of 110 relevant lines covered (100.0%)

1403.05 hits per line