umputun / stash / 20645439659

84%

Build Type

push

github

Committed by web-flow

Commit Message

refactor(auth): extract auth package and simplify interfaces (#54)

* refactor(auth): extract auth package and simplify interfaces

split ~900 line auth.go into app/server/auth/ package with 3 files:
- config.go: types and yaml parsing
- auth.go: Service struct and methods
- middleware.go: HTTP middleware and helpers

simplified consumer interfaces:
- api.AuthProvider: reduced from 7 to 3 methods
- server.AuditAuth: reduced from 4 to 2 methods

added request-based auth methods that encapsulate internal logic:
- FilterKeysForRequest(r, keys) replaces manual token/session/public checks
- IsRequestAdmin(r) replaces HasTokenACL + IsTokenAdmin + IsAdmin combo
- GetRequestActor(r) returns actor type and name from request

naming follows go conventions (avoid stuttering):
- auth.Service instead of auth.Auth
- auth.New instead of auth.NewAuth
- auth.Config instead of auth.AuthConfig

related #audit-ui

* fix(auth): address code review findings

- remove dead auth.Noop function and its test
- remove empty "service disabled" test subtests
- add TestService_Activate for Activate() method
- add ConfigValidator callback tests
- add TokenMiddleware list operation tests
- simplify initAuthService to single return value
- update CLAUDE.md with new auth package structure

* refactor(auth): make internal methods private

reduce public API surface by making methods private that are only used
within the auth package:
- getTokenACL, hasTokenACL, checkPermission
- filterTokenKeys, filterPublicKeys
- isTokenAdmin, validateSession, getPublicACL
- merge ValidateUser into IsValidUser (eliminate wrapper)

* fix(auth): address code review findings and add integration tests

- Fix token masking inconsistency: GetRequestActor now uses MaskToken() for consistent 4-char format
- Remove validateSession: duplicated GetSessionUser logic, updated all callers
- Remove dead code: getPublicACL (test-only) and unreachable zero interval check in startCleanup
- Fix no-assertion test: TestServ... (continued)

Run Details

643 of 718 new or added lines in 8 files covered. (89.55%)

23 existing lines in 2 files now uncovered.

3977 of 4742 relevant lines covered (83.87%)

78.75 hits per line