umputun / stash / 20645406668

84%

master: 84%

Build Type

Pull #54

github

Committed by umputun

Commit Message

fix(auth): address code review findings and add integration tests

- Fix token masking inconsistency: GetRequestActor now uses MaskToken() for consistent 4-char format
- Remove validateSession: duplicated GetSessionUser logic, updated all callers
- Remove dead code: getPublicACL (test-only) and unreachable zero interval check in startCleanup
- Fix no-assertion test: TestService_startWatcher_ContextCancel now verifies watcher stops
- Reduce TokenMiddleware nesting: extract checkSessionAuth helper for session validation
- Add integration tests for X-Auth-Token header, public ACL, and API list filtering

Pull Request Pull Request #54: refactor(auth): extract auth package and simplify interfaces

Run Details

643 of 718 new or added lines in 8 files covered. (89.55%)

23 existing lines in 2 files now uncovered.

3977 of 4742 relevant lines covered (83.87%)

78.75 hits per line