umputun / stash / 20637072238

84%

master: 84%

Build Type

Pull #54

github

Committed by umputun

Commit Message

refactor(auth): extract auth package and simplify interfaces

split ~900 line auth.go into app/server/auth/ package with 3 files:
- config.go: types and yaml parsing
- auth.go: Service struct and methods
- middleware.go: HTTP middleware and helpers

simplified consumer interfaces:
- api.AuthProvider: reduced from 7 to 3 methods
- server.AuditAuth: reduced from 4 to 2 methods

added request-based auth methods that encapsulate internal logic:
- FilterKeysForRequest(r, keys) replaces manual token/session/public checks
- IsRequestAdmin(r) replaces HasTokenACL + IsTokenAdmin + IsAdmin combo
- GetRequestActor(r) returns actor type and name from request

naming follows go conventions (avoid stuttering):
- auth.Service instead of auth.Auth
- auth.New instead of auth.NewAuth
- auth.Config instead of auth.AuthConfig

related #audit-ui

Pull Request Pull Request #54: refactor(auth): extract auth package and simplify interfaces

Run Details

640 of 737 new or added lines in 8 files covered. (86.84%)

23 existing lines in 2 files now uncovered.

3974 of 4761 relevant lines covered (83.47%)

78.26 hits per line