google / authenticode-rs / 20546136716

88%

Build Type

push

github

Committed by nicholasbishop

Commit Message

Relax checks on signed_attrs

This crate has some checks on signed attributes that are much stricter
than what is required by windows. For instance:

1. Windows accepts having no signed attributes. In this case, it
   assumes the signature is done over the embedded message data instead
   of the signed attributes.

2. Windows accepts a signed-attributes with no content-type attr. In
   fact, it even accepts one with an invalid/mismatched content-type -
   it looks like windows completely ignores that attribute.

The only check really necessary is that, if signed attributes _are_
present, it must contain a message-digest attribute.

Run Details

5 of 6 new or added lines in 1 file covered. (83.33%)

1 existing line in 1 file now uncovered.

420 of 476 relevant lines covered (88.24%)

7.41 hits per line