screwdriver-cd / queue-service / #249

87%

push

screwdriver

fix: remove blockedBy.toString() and require('cjson') (#82)

This commit fixes two critical bugs causing build validation and cleanup failures:

1. ValidationError: "value" must be an object
   - blockedBy was being converted from array [142288] to string "142288"
   - This caused executor-base validation to fail for both start and stop jobs
   - Fixed by removing .toString() calls in scheduler.js lines 496 and 766

2. Lua script error: nonexistent global variable 'require'
   - stopBuild.lua had require("cjson") which is not needed
   - cjson is available globally in Redis Lua environment
   - Removed the require statement

Impact:
- Start jobs now pass validation and execute properly
- Stop jobs now run and clean up Redis keys (running_job_*, buildConfigs)
- Builds show correct "Blocked by" messages with build IDs
- No more stuck builds blocking other builds indefinitely

334 of 410 branches covered (81.46%)

Branch coverage included in aggregate %.

1 of 1 new or added line in 1 file covered. (100.0%)

1067 of 1194 relevant lines covered (89.36%)

27.17 hits per line