ThePalaceProject / web-patron / 20477333538

77%

push

github

Show error and prevent loop for SAML sign on failure (PP-3392) (#86)

## Description

- Prevents a infinite loop during SAML sign on if the Palace Manager is
unable to extract a unique patron authorization identifier from the SAML
Subject assertion after authentication succeeds at the identity
provider.
- Displays an error message and "Try again" prompt if an error is
returned from the Palace Manager server back end.

## Motivation and Context

Previously, when a SAML user was able to authenticate with their
Identity Provider, but received an error from the back end after being
redirected to the Palace Manager with the SAML response, the app would
go into an infinite loop when on the "My Book" page. This happened
because:
- that page requires authentication;
- the user has already authenticated with the SAML IdP (so won't be
prompted again); and
- there was not a check for the error from the Palace Manager (a failure
would redirect to the "My Books" page and start the cycle all over
again).

[Jira PP-3392]

## How Has This Been Tested?

- Manually tested success and failure scenarios in dev environment.
- Added tests for the new checks and UI.
- All tests pass in local dev environment.
- [CI
tests](https://github.com/ThePalaceProject/web-patron/actions/runs/20442378522)
pass.

## Checklist:

- [x] I have updated the documentation accordingly.
- [x] All new and existing tests passed.

57 of 74 branches covered (77.03%)

Branch coverage included in aggregate %.

71 of 92 relevant lines covered (77.17%)

11.84 hits per line