dcdpr / jp / 20471682155

58%

push

github

fix(storage): fix deletion of ephemeral conversations with titles (#335)

Previously, `remove_ephemeral_conversations` constructed the path for
deletion using `to_dirname(None)`, assuming conversations had no title
suffix in their directory name. This caused the cleanup to fail for
ephemeral conversations that had been assigned a title, as the
calculated path did not match the actual directory on disk.

This commit updates the path construction to use the actual conversation
title, ensuring the correct directory is targeted for removal.

Additionally, `ConversationId::from_dirname` has been renamed to
`try_from_dirname` to better reflect that it returns a `Result`,
adhering to standard Rust naming conventions.

---------

Signed-off-by: Jean Mertz <git@jeanmertz.com>

6 of 6 new or added lines in 2 files covered. (100.0%)

8936 of 17323 relevant lines covered (51.58%)

131.75 hits per line