babelfish-for-postgresql / babelfish_extensions / 20465064017

77%

Build Type

push

github

Committed by web-flow

Commit Message

Setting recurse to true for cases where we want to find the ENRs by traversing parent queryEnvs (#4334)


    Function - pltsql_get_tsql_enr_from_oid is used in the below cases -
        lmgr -> within CheckRelationLockedByMe to check if the given relation is locked by a bknd. this is safe to go over parent queryEnvs.
        lock -> when trying to acquire a lock on a rel. This is what causes the waiting when trying to operate on temp table in the parent queryEnv scope. we've also verified the behaviour with TSQL.
        inval -> when deciding whether we want to put inval msg in the SI queue. This is also not a problem.
        We will want to go recursively to search for ENR in all cases; hence setting recurse to true.

    Function - object_name is used for getting the name given obj_oid and db_oid. But in TSQL, temp tables do not have a object_id and hence object_name also does not work. Hence, in this case, we will keep the recurse = false.

Tasks: BABEL-5605, BABEL-6192

Engine PR: babelfish-for-postgresql/postgresql_modified_for_babelfish#665

Signed-off-by: Ayush Shah <ayushdsh@amazon.com>

Run Details

2 of 2 new or added lines in 2 files covered. (100.0%)

2 existing lines in 1 file now uncovered.

52480 of 68279 relevant lines covered (76.86%)

387875.67 hits per line