kubevirt / hyperconverged-cluster-operator / 20432692879

76%

push

github

Change VAP's owner to the hyperconverged CRD (#3924)

* Change VAP's owner to the hyperconverged CRD

The validating admission policy and binding owner reference is the HCO
deployment, so they should be auto removed when the HCO deployment is
removed.

But this is not working, because the deployment is namespace scoped
while the policy and the binding are cluster scope, and this is not
supported by kubernetes.

This PR changes the owner reference to the hyperconverged CRD. CRDs are
cluster scoped so now the deletion works. It also makes sense, because
the policy is a validation of a resource, defined by the CRD.

Now, when deleting the CRD (after deleting the HCO deployment), the
policy and the binding are removed as well, automatically.

Also, fixed a potential bug in the policy and binding predicates, that
may ignore delete event.

Signed-off-by: Nahshon Unna Tsameret <nahsh.ut@gmail.com>

* adding a missing log

log when updating the labels of the bearer token secret.

Signed-off-by: Nahshon Unna Tsameret <nahsh.ut@gmail.com>

---------

Signed-off-by: Nahshon Unna Tsameret <nahsh.ut@gmail.com>

17 of 44 new or added lines in 3 files covered. (38.64%)

8327 of 10883 relevant lines covered (76.51%)

1.81 hits per line