Alan-Jowett / CoPilot-For-Consensus / 20423422233

78%

push

github

Add Azure Monitor–Backed MetricsAdapter to copilot_metrics (#524)

* Initial plan

* Add Azure Monitor metrics adapter with OpenTelemetry integration

Co-authored-by: Alan-Jowett <20480683+Alan-Jowett@users.noreply.github.com>

* Fix linting issues in Azure Monitor adapter (10/10 pylint score)

Co-authored-by: Alan-Jowett <20480683+Alan-Jowett@users.noreply.github.com>

* Fix type annotations and test skip conditions per code review

Co-authored-by: Alan-Jowett <20480683+Alan-Jowett@users.noreply.github.com>

* Changes before error encountered

Co-authored-by: Alan-Jowett <20480683+Alan-Jowett@users.noreply.github.com>

* Address code review feedback: add test fixture, improve assertions, rename test

Co-authored-by: Alan-Jowett <20480683+Alan-Jowett@users.noreply.github.com>

* Fix CI failure: remove undefined monkeypatch reference in test

Co-authored-by: Alan-Jowett <20480683+Alan-Jowett@users.noreply.github.com>

* Fix test fixture usage and skip condition logic

- Use mock_azure_exporter fixture consistently across all Azure Monitor tests
- Fix inverted skip condition in test_requires_azure_monitor_packages
- Remove all inline mocking code duplication

Co-authored-by: Alan-Jowett <20480683+Alan-Jowett@users.noreply.github.com>

* Fix Azure Monitor implementation issues per code review

- Store provider instance to avoid global state conflicts
- Fix gauge callback closure to capture key by value
- Initialize cache dictionaries before try block for consistent state
- Use instance-specific provider in shutdown instead of global
- Update test comment for accuracy
- Add mock_azure_exporter fixture to factory test

Co-authored-by: Alan-Jowett <20480683+Alan-Jowett@users.noreply.github.com>

* Add get_gauge_value method and use f-string logging for consistency

- Add get_gauge_value() method to support test introspection like NoOp collector
- Convert all logging to f-strings for consistency with Prometheus adapter
- Maintains consistency across metrics ... (continued)

32 of 142 new or added lines in 3 files covered. (22.54%)

5467 of 7108 relevant lines covered (76.91%)

0.86 hits per line