gnosisguild / zodiac-modifier-roles / 20410257753

94%

main: 96%

Pull #393

github

New Operator.Pluck (#416)

* Add Pluck operator for value extraction and reference. Make use of it in WithinRatio comparisons

* Simplify WithinRatioChecker comments

* Add Encoding.EtherValue to use transaction value with existing operators

  - New EtherValue encoding allows ether value as data source for operators like
    WithinAllowance, Pluck, and comparisons (EqualTo, GreaterThan, LessThan)
  - Integrity validates EtherValue usage (no children, not under Array, compatible operators)
  - EtherValue patched to None after validation, enabling detection via payload.size == 0
  - __word function returns context.value when payload.size == 0

* Remove EtherWithinAllowance, becomes deprecated, in favour of EtherValue with existing comparison operators

* Rename IPriceAdapter to IPricing

* Store EqualTo compValue raw for ≤32 bytes, hash only when >32 bytes

* Enforce encoding-specific compValue length for EqualTo

* Support EtherValue with EqualTo operator

* Rename _address to _calculateAddress in ImmutableStorage

* Optimize ImmutableStorage.load with single assembly block. Saves the default zero-initialization since extcodecopy overwrites it anyway

* Update operator comments to reflect EtherValue support

* Enforce Array operators to only have structural children, remove redundant firstStructuralParent check

* Restrict EqualToAvatar to Static encoding only

---------

Co-authored-by: Cristóvão <cristovaoth@users.noreply.github.com>

602 of 656 branches covered (91.77%)

Branch coverage included in aggregate %.

1068 of 1161 relevant lines covered (91.99%)

340.59 hits per line