Alan-Jowett / CoPilot-For-Consensus / 20348362291

78%

push

github

Handle pika transport state assertion errors during shutdown (#402)

* Initial plan

* Add graceful handling for pika transport state errors

- Catch AssertionError from pika's _AsyncTransportBase during shutdown
- Log transport state errors as warnings instead of errors
- Prevent service failure due to benign shutdown race conditions
- Add comprehensive tests for error handling scenarios

Co-authored-by: Alan-Jowett <20480683+Alan-Jowett@users.noreply.github.com>

* Address code review: simplify exception handling

- Use `Exception` instead of `(AssertionError, Exception)` in stop_consuming
- AssertionError is a subclass of Exception, making the tuple redundant

Co-authored-by: Alan-Jowett <20480683+Alan-Jowett@users.noreply.github.com>

* Add clarifying comments about pika typo in error message

- Document that "_initate" is a typo in pika, not our code
- Tests reproduce exact error message from pika library
- Prevents confusion during code review

Co-authored-by: Alan-Jowett <20480683+Alan-Jowett@users.noreply.github.com>

* Address code review feedback

- Remove redundant error handling from parsing/main.py (handled in RabbitMQSubscriber)
- Add finally block to always reset _consuming flag on exit
- Make stop_consuming exception handling more specific
- Improve test coverage for error detection and state management
- Remove test_main_error_handling.py (no longer needed)

Co-authored-by: Alan-Jowett <20480683+Alan-Jowett@users.noreply.github.com>

* Remove redundant test code

- Remove duplicate stop_consuming() call and assertion in test
- The test already verified the flag reset properly

Co-authored-by: Alan-Jowett <20480683+Alan-Jowett@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: Alan-Jowett <20480683+Alan-Jowett@users.noreply.github.com>

15 of 15 new or added lines in 1 file covered. (100.0%)

4596 of 5526 relevant lines covered (83.17%)

0.94 hits per line