Alan-Jowett / CoPilot-For-Consensus / 20348032288

78%

push

github

Replace return-code error signaling with exceptions to prevent silent failures (#395)

* Initial plan

* Add custom exception classes and refactor ingestion/parsing services

- Created custom exception hierarchies for ingestion and parsing services
- Refactored ingestion service to raise exceptions instead of returning False
- Updated ingestion main.py to handle exception-based results
- Refactored parsing service to raise exceptions for missing required fields
- Changed ingest_all_enabled_sources to return Dict[str, Optional[Exception]]

Co-authored-by: Alan-Jowett <20480683+Alan-Jowett@users.noreply.github.com>

* Update parsing service and tests for exception-based error handling

- Updated parsing service to handle new exception-based parse_mbox interface
- Updated parsing tests to expect exceptions instead of error tuples
- Updated ingestion tests to validate exception-raising behavior
- Added new tests for exception scenarios (SourceConfigurationError, FetchError)

Co-authored-by: Alan-Jowett <20480683+Alan-Jowett@users.noreply.github.com>

* Complete exception-based error handling refactor with documentation

- Created EXCEPTION_HANDLING_AUDIT.md documenting all changes
- Added comprehensive test demonstrating exception benefits
- All Python syntax validated successfully
- Migration guide included for developers

Co-authored-by: Alan-Jowett <20480683+Alan-Jowett@users.noreply.github.com>

* Fix failing CI tests for exception-based error handling

- Updated ingestion integration tests to expect Dict[str, Optional[Exception]] instead of Dict[str, bool]
- Fixed test_archive_ingestion_failed_event_schema_validation to catch FetchError exception
- Removed tuple unpacking from parsing tests (parse_mbox no longer returns tuple)
- Updated test_message_without_message_id to expect MessageParsingError when all messages fail
- Fixed parsing service to not re-raise exceptions in process_archive (allows graceful event handling)

Co-authored-by: Alan-Jowett ... (continued)

87 of 106 new or added lines in 5 files covered. (82.08%)

4564 of 5495 relevant lines covered (83.06%)

0.94 hits per line