optimizely / agent / 20347157237

87%

push

github

[FSSDK-11558] Mpirnovar add holdouts support (#452)

* Add holdouts support to Agent

This change adds holdout support to Agent by:

1. Updating to use local go-sdk with holdouts implementation
2. Adding GetHoldoutList and GetHoldoutsForFlag methods to TestProjectConfig mock
3. Migrating CMAB prediction endpoint config from global variable to CmabConfig struct

Changes:
- Added go.mod replace directive to use local go-sdk for development
- Implemented GetHoldoutList() and GetHoldoutsForFlag() in TestProjectConfig
- Updated CMAB endpoint configuration to use CmabConfig.PredictionEndpointTemplate
- Removed unused cmab package import

Once go-sdk is released with holdouts, the go.mod replace can be removed
and the version bumped to the new release.

* Fix CMAB endpoint tests after API migration

Updated tests to reflect that CMAB prediction endpoint is now configured
through CmabConfig.PredictionEndpointTemplate instead of a global variable.

Removed assertions that checked cmab.CMABPredictionEndpoint since the
endpoint is now encapsulated within the CMAB client configuration and
cannot be easily verified from outside.

The tests still verify that clients are created successfully with the
configured endpoints.

* add uit and acceptance tests

* Remove Holdouts field from OptimizelyConfig API

Updated Agent to use go-sdk branch that removed the Holdouts field from
OptimizelyConfig. This aligns with JavaScript and C# SDKs and fixes FSC test failures.

Agent doesn't need holdouts exposed in OptimizelyConfig because:
- The /v1/decide endpoint uses go-sdk's decision service which handles holdouts
  internally through GetHoldoutsForFlag() and GetHoldoutList() methods
- OptimizelyConfig is for metadata, not decision-making
- Holdout decision logic is already present in go-sdk v2.3.0

Changes:
- Updated go.mod to use go-sdk@mpirnovar-fix-activate-endpoint-holdouts
- Removed TestConfigIncludesHoldouts test
- Removed test_config_with_holdouts and validate_holdout_... (continued)

13 of 13 new or added lines in 1 file covered. (100.0%)

3483 of 4020 relevant lines covered (86.64%)

2747.26 hits per line