umputun / secrets / 20324832388

83%

push

github

feat(email): add email sharing for secure links (#92)

* feat(email): add email sharing for secure links

add optional email sharing feature that allows users to send secure link
via email directly from the UI. when enabled via --email.enabled flag,
a "Send Email" button appears next to "Copy Link" on the secure link page.

- add go-pkgz/notify for SMTP email sending
- implement EmailSender interface with dependency injection pattern
- add email popup modal with subject, from, to, cc fields and preview
- support configurable SMTP settings via CLI flags
- include default HTML email template with customization option

* fix(ui): remove misleading time values from closePopup events

the javascript handler ignores the time parameter and closes the popup
immediately. changed from "2s"/"3s" strings to boolean true to reflect
actual behavior and avoid confusion.

* refactor(email): improve code quality based on review

- add URL encoding for email popup link parameter
- add GetDefaultFromName to EmailSender interface
- extract emailPopupData named struct type
- use RFC 5322 email validation via mail.ParseAddress
- simplify recipient formatting and template loading
- add tests for email web handlers using moq

* fix(email): add link validation and improve code organization

- add isValidSecretLink to prevent phishing relay abuse via email
- fix inconsistent fromName fallback in emailPreviewCtrl
- remove unused ContentType/Charset from EmailConfig
- move isValidEmail from web.go to email.go
- add tests for link validation and CC flow

* refactor(email): restructure package and apply code review fixes

- move email package from app/server/email to app/email for consistency
- extract template to embedded file (email.tmpl.html) instead of inline const
- fix UTF-8 truncation in preview text (use rune-based slicing)
- add link validation to emailPreviewCtrl
- add length limits for subject (200) and fromName (100)
- preserve To/CC form fields on validation errors
- ... (continued)

272 of 384 new or added lines in 7 files covered. (70.83%)

1552 of 1838 relevant lines covered (84.44%)

21.48 hits per line