20263097764
80%

Ran 16 Dec 2025 09:32AM UTC

Jobs 1

Files 34

Run time 1min

Badge

Embed ▾

Committed 16 Dec 2025 09:23AM UTC coverage: 80.459%. Remained the same

Build # 20263097764

Build Type

push

github

Committed by

web-flow

Commit Message

CA-422071: guard against losing Host field settings on pool join (#6799)

This only looks at newly added fields (those with an empty `lifecycle`),
and requires them to be present in `Host.create_params`. This ensures
that we get a compile error, and are forced to propagate it during pool
join.

Otherwise newly added fields seem to keep reintroducing this bug with
every newly added feature (e.g. the pending NTP feature branch has this
bug on most of its fields).

So far I only found this bug on the update guidance fields. There are
more bugs on other pre-existing fields in older releases, but those are
skipped by the unit test (there are too many, `logging`, `iscsi_iqn`,
etc.).
We do want to eventually fix those, but it'll require a lot more
testing, so will be done separately (also some of them are actually
overwritten in dbsync_slave).

There are a lot more properties we could check in the unit test (e.g.
that all newly added parameters have defaults for backwards
compatibility, that the doc and type matches the field, etc.).
Although eventually I'd probably want to entirely auto-generate
`create_params`, but we'll need to see how to do that to also take into
account what dbsync_slave already does.

Run Details

3504 of 4355 relevant lines covered (80.46%)

0.8 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	python3.11 - 20263097764.1	16 Dec 2025 09:32AM UTC	34	80.46	GitHub Action Run

xapi-project / xen-api / 20263097764
80%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 20263097764

xapi-project / xen-api / 20263097764 80%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 20263097764

xapi-project / xen-api / 20263097764
80%

README BADGES
x