umputun / secrets / 20257038396

87%

master: 84%

Build Type

Pull #87

github

Committed by umputun

Commit Message

refactor: address code review findings for file upload feature

- fix loadMessageCtrl to handle file messages (serve download instead of rendering binary as text)
- add constant-time protection to downloadFileCtrl and loadMessageCtrl
- add duration <= 0 validation to MakeMessage for consistency
- refactor MakeFileMessage to use FileRequest struct instead of 5 parameters
- rename messeger.go to messager.go (typo fix)
- extract helpers: serveFileDownload, validatePinValues, sanitizeContentType
- add tests for generateFileLinkCtrl and downloadFileCtrl error paths
- add test for MakeFileMessage engine.Save error propagation
- fix generateFileLinkCtrl to render file-input partial for validation errors

Pull Request Pull Request #87: feat: add file upload/download support

Run Details

362 of 412 new or added lines in 4 files covered. (87.86%)

18 existing lines in 1 file now uncovered.

1261 of 1446 relevant lines covered (87.21%)

17.57 hits per line