Alan-Jowett / CoPilot-For-Consensus / 20256588149

77%

push

github

Remove schema_provider parameter from _build_registry() to prevent inappropriate event-envelope lookups (#279)

* Initial plan

* Fix event-envelope schema loading from wrong provider

Remove schema_provider parameter from _build_registry() to prevent
event-envelope.schema.json from being requested from document schema
providers. The event envelope should only be loaded from filesystem,
not from arbitrary schema providers.

Changes:
- Remove schema_provider parameter from _build_registry()
- Update validate_json() to call _build_registry() without argument
- Mark schema_provider parameter as deprecated in validate_json()
- Add test to verify event-envelope is not requested from providers

Fixes issue where ValidatingDocumentStore caused warnings when trying
to load event-envelope from document schema directories.

Co-authored-by: Alan-Jowett <20480683+Alan-Jowett@users.noreply.github.com>

* Fix linting issues (whitespace and unused import)

- Remove trailing whitespace from lines
- Remove unused import (call) from test file
- Ensure flake8 compliance

Co-authored-by: Alan-Jowett <20480683+Alan-Jowett@users.noreply.github.com>

* Improve deprecation notice for schema_provider parameter

Add guidance on when parameter will be removed and what action
developers should take (remove the argument from their calls).
Addresses code review feedback.

Co-authored-by: Alan-Jowett <20480683+Alan-Jowett@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: Alan-Jowett <20480683+Alan-Jowett@users.noreply.github.com>

9 of 10 new or added lines in 1 file covered. (90.0%)

4082 of 4896 relevant lines covered (83.37%)

0.95 hits per line