Alan-Jowett / CoPilot-For-Consensus / 20247278636

77%

push

github

Refactor/enforce typed config api (#261)

* refactor: enforce typed config API for compile-time safety

- Remove load_config from public API (only internal _load_config available)
- Rename load_config to _load_config in schema_loader.py
- Update __init__.py to only export load_typed_config
- All services now must use load_typed_config (validated config)
- Trying to import load_config fails at import time
- Update all test calls to use _load_config
- Update documentation and examples to show load_typed_config
- Update ingestion/upload_ingestion_sources.py to use load_typed_config

This enforces that all configuration is validated against schemas at compile time.
No service can accidentally load unvalidated configuration.

* Replace DOC -> DOCUMENT in environment variable names

Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>

* refactor: make TypedConfig truly attribute-only with immutability

- Remove __getitem__, get(), __contains__ methods (dict-style access)
- Add explicit __getitem__ that raises helpful TypeError
- Add __setattr__ to prevent runtime modifications (immutable config)
- Add __dir__ for IDE autocomplete of available keys
- Update README to document attribute-only design
- Update examples to use only attribute access
- Configuration now enforces both: validated at load time + safe access

This enables better static analysis, IDE support, and prevents accidental
misuse of configuration objects at runtime.

* test: update TypedConfig tests for attribute-only immutable API

- Update test_dict_style_access to expect TypeError when using dict-style access
- Update test_get_with_default to expect AttributeError for removed .get() method
- Update test_missing_key_raises_error to expect TypeError from dict-style access
- Update test_to_dict to expect AttributeError for removed .to_dict() method
- Update test_contains to expect TypeError for 'in' operator
- Add test_immutability to verify config is immutable after loading

All 77 tests n... (continued)

35 of 45 new or added lines in 4 files covered. (77.78%)

4046 of 4868 relevant lines covered (83.11%)

0.94 hits per line