mozilla-releng / balrog / #5068

90%

main: 89%

push

circleci

Memoize minDateTime in the DateTimePicker (#3596)

Something I saw while editing rules, if you are unlucky enough to start
editing rules towards the end of a minute (or if you're slow), the
scheduled time will fall off and the form will show a very unhelpful
"minTime" error on it. That happens because the component gets the
min time on every render (so it follows the current time) which is great
if we actually cared about not having times in the past. We do in fact
not care a single bit. The only reason to have a min time at all is to
help prevent egregious mistakes like "oops, wrong day, wanted to +1,
ended up -1"...

Instead of moving the minTime target, memoize it when the component gets
mounted so it stays the same throughout the form lifetime.

2165 of 2546 branches covered (85.04%)

Branch coverage included in aggregate %.

5730 of 6236 relevant lines covered (91.89%)

0.92 hits per line