Alan-Jowett / CoPilot-For-Consensus / 20221648217

77%

push

github

fix: Make FileSchemaProvider fail fast and correct chunking schema path (#234)

* fix: make FileSchemaProvider fail fast and correct chunking schema path

- FileSchemaProvider now raises FileNotFoundError if schema directory doesn't exist
- FileSchemaProvider now raises NotADirectoryError if schema path is not a directory
- Fixed chunking service schema path from Path(__file__).parent.parent to Path(__file__).parent
- Removed unnecessary null checks in get_schema() and list_event_types()

This ensures services fail fast at startup rather than at runtime when schemas are missing.

Fixes #233

* test: update FileSchemaProvider tests to expect fail-fast behavior

- test_nonexistent_schema_dir now expects FileNotFoundError
- test_list_event_types_no_schema_dir now expects FileNotFoundError

These tests were expecting the old behavior where the provider would
continue with schema_dir=None. Now that the provider fails fast,
the tests have been updated to verify the exception is raised.

* Potential fix for code scanning alert no. 2: Workflow does not contain permissions (#225)

* Potential fix for code scanning alert no. 2: Workflow does not contain permissions

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>

* PR feedback

Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>

* Delete Cancel-All-GithubRuns.ps1

---------

Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Co-authored-by: Alan Jowett <alan.jowett@microsoft.com>

* fix: implement queue draining and improve duplicate error handling (#232)

- Fix queue consumption pattern: services now consume from event-type queues (archive.ingested, json.parsed, chunks.prepared, summary.complete) instead of service-specific queues
- Improve error handling in parsing service: DuplicateKeyError and DocumentValidationError are now ... (continued)

8 of 8 new or added lines in 1 file covered. (100.0%)

2760 of 3357 relevant lines covered (82.22%)

0.98 hits per line