Alan-Jowett / CoPilot-For-Consensus / 20211881776

79%

push

github

Replace broad exception catching with specific exception types (#166)

* Replace broad exception catching with specific exceptions

- Replace Exception with specific connection/network exceptions in RabbitMQ test fixture
- Replace Exception with specific connection/attribute exceptions in Qdrant vector store
- Replace Exception with specific connection/type exceptions in config providers
- Add descriptive comments explaining error handling rationale

Co-authored-by: Alan-Jowett <20480683+Alan-Jowett@users.noreply.github.com>

* Add tests for specific exception handling

- Add tests for DocStoreConfigProvider exception handling (Connection, OS, Timeout, Attribute, Type, Key errors)
- Add tests for QdrantVectorStore exception handling during ID existence checks
- Add tests for SchemaConfigLoader exception handling during storage loads
- Verify that specific exceptions are caught and handled gracefully with fallback behavior

Co-authored-by: Alan-Jowett <20480683+Alan-Jowett@users.noreply.github.com>

* Fix test method names for schema_loader tests

- Rename _load_from_storage to _load_storage_collection to match actual implementation
- Corrects test references to use the correct method name

Co-authored-by: Alan-Jowett <20480683+Alan-Jowett@users.noreply.github.com>

* Add missing test cases for AttributeError, TypeError, and KeyError

- Add test for AttributeError in add_embedding() method
- Add test for AttributeError in add_embeddings() batch method
- Add tests for TypeError and KeyError in schema_loader
- Addresses review comments requesting complete test coverage for all exception types

Co-authored-by: Alan-Jowett <20480683+Alan-Jowett@users.noreply.github.com>

* Fix config adapter exception handling to properly propagate errors

- Modified _ensure_cache() to propagate exceptions instead of setting cache to empty dict
- Added KeyError to is_connected() exception handling
- Added exception handling in get() method to return defaults when cache fai... (continued)

14 of 16 new or added lines in 3 files covered. (87.5%)

952 of 1359 relevant lines covered (70.05%)

0.7 hits per line