Alan-Jowett / CoPilot-For-Consensus / 20203152273

79%

push

github

Add assertions to 19 test functions that validated behavior without verification (#175)

* Initial plan

* Add assertions to all test functions without them

Co-authored-by: Alan-Jowett <20480683+Alan-Jowett@users.noreply.github.com>

* Address code review feedback: improve assertion quality

Co-authored-by: Alan-Jowett <20480683+Alan-Jowett@users.noreply.github.com>

* Revert test_integration.py functions to return booleans for main() usage

Co-authored-by: Alan-Jowett <20480683+Alan-Jowett@users.noreply.github.com>

* Refactor exception tests to use pytest.raises pattern

Co-authored-by: Alan-Jowett <20480683+Alan-Jowett@users.noreply.github.com>

* Fix malformed event handling to ensure guaranteed forward progress

- Raise exceptions for missing/invalid required fields in event data
- Chunking: Validate parsed_message_ids exists and is a list
- Parsing: Raise KeyError when archive_id or file_path missing
- Summarization: Validate thread_ids exists and is a list
- Allow empty message/thread lists as valid cases
- Update tests to expect ValueError/KeyError/TypeError appropriately

This ensures at-least-once delivery: malformed events trigger nack/requeue
instead of being silently acked and lost.

* Fix embedding service forward progress guarantees: add strict validation and exception re-raising

- Add explicit validation that chunk_ids field exists (raises ValueError if missing)
- Add type validation that chunk_ids is a list (raises TypeError if not)
- Distinguish between missing field (error) vs empty field (valid)
- Re-raise exceptions after max retries to trigger message requeue
- Add exception handling with re-raise to event publishing methods
- Add 6 new unit tests to verify malformed event handling
- Update test_process_chunks_max_retries_exceeded to expect exception

This ensures the embedding service implements guaranteed forward progress semantics:
- Malformed events (missing/invalid fields) trigger message requeue
- Transient errors after m... (continued)

177 of 201 new or added lines in 7 files covered. (88.06%)

1278 of 1502 relevant lines covered (85.09%)

0.85 hits per line