elParaguayo / qtile / 20189821644

83%

Build Type

push

github

Committed by elParaguayo

Commit Message

widgets: separate Volume and PulseVolume

Because PulseVolume inherits from Volume, it also inherits all of the
timers, which means it still runs commands to find the volume, even if it
can get them over the wire from pulse.

Instead, let's hoist the common code (mostly icon resolution, formatting,
and rendering) to VolumeBase, and have each inherit from it with their own
implementation for actually getting the volume.

Signed-off-by: Tycho Andersen <tycho@tycho.pizza>

Run Details

31 of 41 new or added lines in 2 files covered. (75.61%)

4 existing lines in 1 file now uncovered.

16589 of 20347 relevant lines covered (81.53%)

4.44 hits per line