optimizely / go-sdk / 20182503213

92%

master: 92%

Pull #431

github

Remove Holdouts field from OptimizelyConfig

The Holdouts field was not part of the original TDD requirements and is not
present in JavaScript or C# SDKs. This field was causing FSC test failures.

Agent doesn't need holdouts exposed in OptimizelyConfig because:
- Decision logic (GetHoldoutsForFlag, GetHoldoutList) works internally
- Agent's /v1/decide endpoint uses go-sdk's decision service which already
  handles holdouts from v2.3.0
- OptimizelyConfig is metadata, not for decision-making

Changes:
- Removed Holdouts field from OptimizelyConfig struct
- Removed OptimizelyHoldout type
- Removed getHoldouts() and getHoldoutAudiences() helper functions
- Removed holdout-specific tests (TestOptlyConfigIncludesHoldouts,
  TestOptlyConfigWithHoldouts)
- Updated TestStaticGetOptimizelyConfig to not expect Holdouts field

The ProjectConfig interface methods (GetHoldoutList, GetHoldoutsForFlag)
remain as they are required by TDD for internal decision logic.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>

0 of 3 new or added lines in 1 file covered. (0.0%)

5631 of 6127 relevant lines covered (91.9%)

7956.33 hits per line