stacklok / toolhive / 20173112592

58%

Build Type

push

github

Committed by web-flow

Commit Message

Composite Tools Supports DefaultResults for Skippable Steps (#3006)

Changes
Schema & Configuration

Added defaultResults field to WorkflowStep CRD type (map[string]runtime.RawExtension)
Added corresponding fields in raw config, internal config, and composer types
Updated all converters (CRD→config, YAML→config, config→composer)
Validation

Implemented shared validation in workflow_validation.go
Validates that defaultResults[field] is specified when:
Step may be skipped (has condition or onError.action: continue)
Downstream steps reference that specific output field
Validation is reused by both VirtualMCPServer and VirtualMCPCompositeToolDefinition webhooks
Template Reference Extraction

Created pkg/templates/references.go with AST-based template parsing
Uses text/template/parse package for reliable reference extraction
Extracts .steps.<stepID>.output.<field> references for validation
Runtime

Updated RecordStepSkipped to accept and store defaultResults as step output
Updated handleToolStepFailure to set defaultResults when continuing on error
Documentation

Added "Default Results" section to virtualmcpcompositetooldefinition-guide.md
Added quick reference to composite-tools-quick-reference.md
Added "Pattern 5: Default Results for Skippable Steps" to advanced-workflow-patterns.md


---------

Signed-off-by: Jeremy Drouillard <jeremy@stacklok.com>

Run Details

204 of 249 new or added lines in 10 files covered. (81.93%)

2 existing lines in 1 file now uncovered.

27542 of 55150 relevant lines covered (49.94%)

57.62 hits per line