lukasoppermann / design-tokens / 20169356520

71%

push

github

feat: add GitHub Direct Commit support (#333)

* feat: add GitHub Direct Commit support

- Add github_commit authentication type for direct file commits
- Implement GithubRepository module for GitHub API integration
- Add UI components for branch, filepath, and commit message configuration
- Update README documentation with github_commit auth option
- Supports automatic branch creation if not exists
- Handles both file creation and updates via GitHub API

* refactor: use URL object for more robust GitHub URL parsing

* docs: add GitHub Direct Commit URL examples to README

* refactor: remove simple owner/repo URL format support

- Remove simple owner/repo format from URL parsing logic
- Update README to document only supported URL formats
- Keep support for https://api.github.com/repos/owner/repo
- Keep support for https://github.com/owner/repo
- Remove :username/:repo format that fails HTML5 validation

* fix: update placeholder to show only supported GitHub URL formats

* docs: simplify GitHub Direct Commit URL format documentation

* fix: address code review feedback

- Add proper URI encoding for filenames with special characters
- Improve 422 status handling to only accept 'Reference already exists'
- Remove redundant targetBranch variable for code clarity

* test: add comprehensive tests for githubRepository module

- Test constructor initialization
- Test upload to existing branch with new/existing files
- Test branch creation when branch doesn't exist
- Test default commit message generation
- Test URL encoding for special characters and unicode
- Mock XMLHttpRequest for isolated unit testing
- Coverage increased from 1.76% to 46.01%

Addresses code review comment about test coverage decrease

* test: improve githubRepository test coverage to 50.44%

- Add tests for URL encoding with slashes
- Add tests for 422 Reference already exists handling
- Add tests for other 422 validation errors
- Add tests for invalid JSON in 422 responses
- Add test... (continued)

377 of 528 branches covered (71.4%)

Branch coverage included in aggregate %.

18 of 123 new or added lines in 2 files covered. (14.63%)

675 of 945 relevant lines covered (71.43%)

4.85 hits per line