speedyk-005 / chunklet-py / 20155307936

87%

main: 87%

Build Type

push

github

Committed by speedyk-005

Commit Message

feat(chunker): Refactor Line De-annotation and Fix Late-Binding Closure Bug

Lint says your code was sus, but now it's iconic. This commit performs critical maintenance and feature stabilization for the code chunker, primarily focusing on eliminating redundant de-annotation and resolving a latent closure bug.

### Bug Fixes

* **Line De-annotation Duplication:** Removed redundant string slicing logic within the chunker's internal processing. The line de-annotation logic was accidentally being called twice: once during the initial regex substitution step, and again via a manual string slice later on. This duplication created ambiguity and was a potential vector for `ghost slicing` where lines could be misinterpreted. We now rely **only** on the regex substitution to perform de-annotation, simplifying the control flow.

* **Late-Binding Closure Fix:** Fixed a classic Python closure bug in the code annotation loop. The original construct `pattern.sub(lambda match: self._annotate_block(tag, match), code)` caused the lambda to reference the final value of `tag` after the loop completed.

    * **The Fix:** Changed to `pattern.sub(lambda match, tag=tag: self._annotate_block(tag, match), code)`. This uses the default argument trick to *capture the current value* of `tag` at definition time, ensuring each regex substitution uses the correct annotation tag.

### Refactoring

* **Default Comments:** Set the `include_comments` parameter to `True` by default in the chunking utility. This aligns with most developer expectations for comprehensive code processing.

* **Code Cleanup:** Minor internal refactoring and code style cleanup (e.g., using explicit variable names for clarity) to enhance readability and maintainability.

Run Details

7 of 10 new or added lines in 3 files covered. (70.0%)

1 existing line in 1 file now uncovered.

1080 of 1322 relevant lines covered (81.69%)

4.08 hits per line