spesmilo / electrum / 6535496685322240

62%

master: 63%

Build Type

Pull #10356

CirrusCI

Committed by SomberNight

Commit Message

transaction: tx_from_any: rm all whitespaces from str, none from bytes

- whitespaces are safe to remove from strings, and is convenient if we do this for users
- bytes-like inputs should be left alone: individual bytes that look like whitespaces can appear in them anywhere
  - even stripping the leading/trailing whitespaces is not safe to do: the first byte of the nVersion or the last byte of the nLocktime might look like whitespace too!
- instead, leading/trailing whitespaces can be stripped closer to where they are input, e.g. in the GUI
  - e.g. ".txn" files that we ourselves create contain a complete tx as a hex string, with a trailing final newline in the file
    - instead of reading that as bytes, we can read it as text
  - ".psbt" files OTOH are binary

Pull Request Pull Request #10356: tx: replace all whitespace chars in raw tx (convert_raw_tx_to_hex)

Run Details

3 of 3 new or added lines in 1 file covered. (100.0%)

1 existing line in 1 file now uncovered.

23729 of 38030 relevant lines covered (62.4%)

0.62 hits per line