facet-rs / facet / 20102737478

58%

push

github

fix: skip static SHAPE declaration for generic types

The `generate_static_decl` function generates a static that pre-evaluates
`<Type as Facet>::SHAPE` in release builds. However, for generic types
like `MyResult<T, E>`, this generated code like:

    static MY_RESULT_SHAPE: &'static Shape = <MyResult as Facet>::SHAPE;

which is invalid because `MyResult` requires generic arguments.

This fix skips generating the static declaration for types with type or
const generics, since we can't create a static for an unmonomorphized
generic type anyway.

Fixes #1225

14 of 14 new or added lines in 3 files covered. (100.0%)

27134 of 46282 relevant lines covered (58.63%)

616.07 hits per line