bramp / build-along / 20044335102

89%

Build Type

push

github

Committed by bramp

Commit Message

Fix subassembly detection when diagrams inside fail during clustering

When SubAssemblyClassifier.build() built diagrams inside a subassembly,
the first diagram would cluster with nearby images and claim them via
_fail_conflicting_candidates(). Subsequent diagram candidates that shared
those images were marked as failed. When the code tried to build those
failed candidates, CandidateFailedError was raised and the entire
subassembly build failed.

Changes:
- Import CandidateFailedError in subassembly_classifier.py
- Skip diagram candidates that already have a failure_reason
- Wrap result.build() in try/except to catch CandidateFailedError and
  continue to next diagram instead of failing the whole subassembly
- Shrink constraint bbox by 3 points when building diagrams inside
  subassemblies to avoid capturing the white border
- Pass constraint_bbox parameter to _build_subassembly_steps()

This fixes page 015 where the subassembly below step 15 wasn't detected.

Run Details

11 of 13 new or added lines in 1 file covered. (84.62%)

189 existing lines in 7 files now uncovered.

11320 of 12572 relevant lines covered (90.04%)

0.9 hits per line