Qiskit / qiskit / 20034337492

88%

Build Type

push

github

Committed by web-flow

Commit Message

Add substitute_node_with_dag to c api (#15374)

* Add substitute_node_with_dag to c api

This commit adds a new function qk_dag_substitute_node_with_dag to the C
api. This facilitates in place substitute from the new dag api. This is
fairly mechanical addition to the api as
`DAGCircuit::substitute_node_with_dag()` is already rust native. So
we only need to expose that inteface to C. The only difference between
the C and existing internal rust interface is that the qubit, clbit, and
var mapping arguments are not exposed to C. These options aren't
commonly used, and if the user needs to map the ordering they can do
that during replacement dag construction rather that at substitution
time.

Fixes #15190

* Panic instead of returning an exit code on failure modes

The failure modes for calling the inner rust method are all caused by
invalid input or aren't possible via the C API (come from python) so
there isn't a reason to have a subpar error experience dealing with
backtraces when it's not something recoverable.

* Run clang format

* Update documentation

---------

Co-authored-by: Jake Lishman <jake.lishman@ibm.com>

Run Details

17 of 19 new or added lines in 1 file covered. (89.47%)

26 existing lines in 5 files now uncovered.

96118 of 108814 relevant lines covered (88.33%)

1206646.12 hits per line