facet-rs / facet / 20027444529

58%

push

github

fix(facet-kdl): simplify children node name override syntax

BREAKING CHANGE: KDL attribute syntax has changed

This commit improves the ergonomics of specifying custom node names for
`kdl::children` fields by moving the node name directly into the attribute:

Before:
  #[facet(kdl::children, kdl::node_name = "kiddo")]
  children: Vec<Child>,

After:
  #[facet(kdl::children = "kiddo")]
  children: Vec<Child>,

This also restores `kdl::node_name` to its original purpose of capturing
the current node's name into a field (previously renamed to `kdl::name`).

Changes:
- Add `OptionalStr` variant kind to attr grammar for Option<&'static str>
- Refactor attr grammar parsing to use unsynn instead of string matching
- Change `kdl::children` and `kdl::child` to accept optional string value
- Rename `kdl::name` back to `kdl::node_name` for capturing node names
- Update deserializer to read node name from children attribute value
- Update all tests and documentation

Fixes: #1182

58 of 79 new or added lines in 3 files covered. (73.42%)

24943 of 42393 relevant lines covered (58.84%)

590.71 hits per line