gluesql / gluesql / 20000719104

98%

Build Type

push

github

Committed by web-flow

Commit Message

Eliminate Literal type by absorbing into Evaluated (#1845)

This PR eliminates the data::Literal type entirely by absorbing its functionality into the existing Evaluated enum in the evaluator layer.

**Background**
The codebase had three overlapping types for representing values during query execution:

* AstLiteral – parsed literal from SQL input
* Literal – intermediate representation for literal operations
* Value – final evaluated result
The Literal type was supposed to handle literal-specific operations (arithmetic, comparison, concatenation, etc.) before converting to Value. However, the Evaluated enum already existed in the evaluator and could handle these cases directly, making Literal an unnecessary intermediate layer.

**What Changed**
- Removed:
data::Literal enum (Boolean, Number, Text, Bytea, Null variants)
data::LiteralError
data::value::ConvertError

- Replaced with:
// Before: Evaluated wrapped Literal
pub enum Evaluated<'a> {
    Literal(Literal<'a>),
    StrSlice { ... },
    Value(Value),
}

// After: Evaluated handles literals directly
pub enum Evaluated<'a> {
    Number(Cow<'a, BigDecimal>),  // numeric literals
    Text(Cow<'a, str>),           // string literals
    StrSlice { ... },
    Value(Value),                  // bool, bytea, null → directly to Value
}

- Error consolidation:

LiteralError → merged into EvaluateError
ConvertError → merged into ValueError::ConvertFailed
New modules under executor/evaluate/evaluated/:

binary_op.rs, unary_op.rs – arithmetic operations
cmp.rs, eq.rs – comparisons
concat.rs, like.rs – string operations
convert/number.rs, convert/text.rs – type conversions

Run Details

1628 of 1628 new or added lines in 17 files covered. (100.0%)

6 existing lines in 2 files now uncovered.

39692 of 40458 relevant lines covered (98.11%)

64601.45 hits per line