winstonjs / winston / 20000787410

71%

push

github

fix: ensure File transport flushes all data before emitting finish (#2594)

Fixes #1504

The File transport was emitting the 'finish' event before all buffered
data was actually written to disk. This caused data loss when calling
logger.end() followed by process.exit().

The root cause was that the transport's internal PassThrough stream
could finish before the underlying fs.WriteStream had flushed to disk.

This adds a _final() method that waits for the destination file stream
to complete before signaling that the transport has finished.

442 of 679 branches covered (65.1%)

Branch coverage included in aggregate %.

8 of 10 new or added lines in 1 file covered. (80.0%)

783 of 1053 relevant lines covered (74.36%)

1109.2 hits per line