stacklok / toolhive / 19960812459

60%

Build Type

push

github

Committed by web-flow

Commit Message

Fix vMCP podTemplateSpec when only pod-level settings is applied (#2897)

* Fix PodTemplateSpec strategic merge wiping containers

When users provided a PodTemplateSpec with only pod-level settings
(like nodeSelector), the Deployment creation failed because containers
were being wiped out.

Root cause: The code parsed user JSON into a Go struct then re-marshaled
it. Go's json.Marshal converts nil slices to [], which strategic merge
patch interprets as "replace with empty array" - removing the vmcp
container.

Fix: Use the raw JSON bytes directly from Spec.PodTemplateSpec.Raw
instead of re-marshaling, preserving exactly what the user specified.

* Add integration test for the vMCP podTemplateSpec

Run Details

6 of 8 new or added lines in 1 file covered. (75.0%)

2 existing lines in 1 file now uncovered.

26323 of 52843 relevant lines covered (49.81%)

59.65 hits per line