safe-global / safe-client-gateway / 19935866643

90%

main: 89%

Build Type

Pull #2830

github

Committed by gjeanmart

Commit Message

feat: add wildcard pattern support for HTTP client endpoint timeouts

The initial implementation of HTTP_CLIENT_ENDPOINT_TIMEOUTS only supported
simple substring matching, which doesn't work for endpoints with dynamic
path segments (e.g., safeAddress in /api/v1/safes/{safeAddress}/...).

This change adds wildcard pattern matching using '*' to match any segment
in the path, while maintaining backward compatibility with simple substring
matching.

Changes:
- Add matchesEndpointPattern() function supporting wildcard patterns
- Update getTimeoutForUrl() to use pattern matching instead of simple includes()
- Add comprehensive tests for wildcard pattern matching scenarios
- Update configuration documentation with wildcard pattern examples

Examples:
- Simple substring: {"endpoint": "all-transactions", "timeout": 30000}
- Wildcard pattern: {"endpoint": "safes/*/multisig-transactions", "timeout": 25000}
  Matches: /api/v1/safes/{anyAddress}/multisig-transactions/ for any address

Patterns are matched in order, with the first match winning.

Pull Request Pull Request #2830: feat: add path-based HTTP client timeout configuration

Run Details

2862 of 3575 branches covered (80.06%)

Branch coverage included in aggregate %.

19 of 33 new or added lines in 3 files covered. (57.58%)

1 existing line in 1 file now uncovered.

13784 of 14911 relevant lines covered (92.44%)

601.79 hits per line