mattwparas / steel / 19916207611

45%

Build Type

push

github

Committed by web-flow

Commit Message

don't crash in log procedure (#575)

* stop steel from crashing in log procedure

before:

```
λ > (log 0 10)

thread 'main' (911264) panicked at crates/steel-core/src/primitives/numbers.rs:2014:78:
argument of integer logarithm must be positive
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
```

after:

```
λ > (log 0 10)
error[E11]: Generic
  ┌─ :1:2
  │
1 │ (log 0 10)
  │  ^^^ log: division by zero (log 0 10)
```

* make (log) always return an inexact number

this is for two reasons:

1. the r7rs spec defines log as an "inexact library procedure" and all
implementations i tested always return a float

2. with this change `(= (log x y) (/ (log x) (log y))` also holds true
when x and y are both integers.

* fix log tests

Run Details

3 of 6 new or added lines in 1 file covered. (50.0%)

30 existing lines in 7 files now uncovered.

15937 of 32358 relevant lines covered (49.25%)

3260009.1 hits per line