pomerium / pomerium / 19909853294

45%

Build Type

push

github

Committed by web-flow

Commit Message

pebble: fix secure fs wrapper (#5967)

## Summary
Fix the secure file system wrapper for pebble. The arguments passed to
`ReuseForWrite` were misinterpreted. It should've been `(oldname,
newname)`, but we were expecting `(newname, oldname)`.

Because the `chmod` failed and the call to `ReuseForWrite` returned an
error, pebble would call `logger.Fatalf` with the error. Since our
logger wrapper just ignored `Fatalf`, this resulted in a confusing panic
"fatal error: sync: unlock of unlocked mutex". (the code expected that
`Fatal` would exit the function immediately, so the subsuqent unlock
should never have been called)

So now the logger is setup to actually log things, except `Info` will be
sent to `Debug` instead, since these logs are pretty noisy.

No AI was used for this PR.

## Related issues
-
[ENG-3266](https://linear.app/pomerium/issue/ENG-3266/corepebble-fatal-error-sync-unlock-of-unlocked-mutex)

## Checklist

- [x] reference any related issues
- [x] updated unit tests
- [x] add appropriate label (`enhancement`, `bug`, `breaking`,
`dependencies`, `ci`)
- [x] ready for review

Run Details

12 of 25 new or added lines in 1 file covered. (48.0%)

12 existing lines in 5 files now uncovered.

28991 of 53940 relevant lines covered (53.75%)

91.37 hits per line