safe-global / safe-client-gateway / 19897784682

89%

push

github

feat: add endpoint to report false Blockaid scan results (COR-636) (#2815)

* feat: add endpoint to report false Blockaid scan results (COR-636)

- Add POST /v1/chains/:chainId/security/:safeAddress/report-false-result endpoint
- Support reporting FALSE_POSITIVE and FALSE_NEGATIVE scan results
- Use request_id from original scan response to identify the transaction
- Add reportTransaction method to BlockaidApi and ThreatAnalysisService
- Handle errors gracefully with logging and success: false response
- Add chain ID to Blockaid chain name mapping (for future use)
- Add comprehensive unit tests

* feat: add request_id to threat analysis response

- Extract request_id from x-request-id header in Blockaid API response
- Extend TransactionScanResponse with request_id field
- Include request_id in ThreatAnalysisResponse for reporting false positives

* refactor: address PR review comments for COR-636

- Refactor ReportEvent to follow ContractStatus pattern with const array
- Add comprehensive documentation for enum types and DTOs
- Explain 1000 char limit is CGW-imposed safeguard
- Remove underscore prefixes from controller params
- Add comment explaining params are for URL validation

* refactor: update request_id handling and logging in SafeShield and ThreatAnalysis services

- Change request_id type from string | null to string | undefined in various services and DTOs.
- Update logging messages to use 'warn' instead of 'error' for reporting failures in SafeShieldService.
- Adjust unit tests to reflect changes in request_id handling and logging behavior.
- Ensure consistency in request_id usage across the threat analysis module.

* test: update mock response in ThreatAnalysisService tests to handle undefined request_id

- Modify the mock response in the ThreatAnalysisService unit tests to set request_id as undefined instead of null, ensuring consistency with recent refactoring changes in request_id handling.

* refactor: update reportTransaction method ... (continued)

2852 of 3545 branches covered (80.45%)

Branch coverage included in aggregate %.

30 of 32 new or added lines in 8 files covered. (93.75%)

13785 of 14901 relevant lines covered (92.51%)

634.22 hits per line