facet-rs / facet / 19892705258

58%

Build Type

push

github

Committed by fasterthanlime

Commit Message

Fix function pointer comparison warning in define_attr_grammar!

The macro generates enums with PartialEq derived, but some variants contain
function pointers (DefaultInPlaceFn, SkipSerializingIfFn, etc.). Comparing
function pointers is unreliable across codegen units.

Instead of deriving PartialEq, generate a manual implementation that:
- Uses regular equality for unit, string, char, and struct variants
- Always returns false for function pointer variants (comparison is meaningless)
- Uses core::ptr::eq for Shape references

Fixes #1001

Run Details

20 of 23 new or added lines in 1 file covered. (86.96%)

1 existing line in 1 file now uncovered.

20533 of 34897 relevant lines covered (58.84%)

538.51 hits per line