facet-rs / facet / 19883129620

58%

Build Type

push

github

Committed by fasterthanlime

Commit Message

Fix Option<Enum> variant detection with niche optimization

When peeking at Option<Enum> where the inner enum uses niche
optimization, the previous "all bytes zero = None" heuristic was
incorrect. For enums like `#[repr(u8)] enum E { Variant }`, Rust uses
a non-zero value to represent None, not zero.

Now uses OptionVTable::is_some_fn to correctly determine the active
variant for Option types, which handles all niche optimization cases.

Fixes #998

Run Details

11 of 12 new or added lines in 1 file covered. (91.67%)

29 existing lines in 1 file now uncovered.

20515 of 34876 relevant lines covered (58.82%)

538.81 hits per line