tarantool / tarantool / 19858249643

88%

master: 88%

Build Type

push

github

Committed by sergepetrenko

Commit Message

memtx: unify `replace_all_keys` code paths w/ and w/o MVCC

Currently, we have 2 separate code paths for `memtx_replace_all_keys` w/
and w/o transaction management inside and outside the memtx transaction
manager.

Let's instead have a common replace code path in the transaction manager.
Without MVCC, we will only replace tuples in indexes, as before. With MVCC,
we will omit physical index replaces in case of deletes or perform deferred
conflict resolution, determine result tuple and track read and write sets.

This way the transaction management API will become easier to scale for
multikey indexes (gh-6385) which require a series of ordinary index
replaces.

To improve the coverage of memtx MVCC and make sure this refactoring does
not cause regressions, let's add test cases for the failure paths of index
replaces.

Closes #11732
Needed for #6385

NO_CHANGELOG=refactoring
NO_DOC=refactoring

(cherry picked from commit f88279e59)

Coverage Stats

69835 of 117633 branches covered (59.37%)

44 of 47 new or added lines in 2 files covered. (93.62%)

73 existing lines in 16 files now uncovered.

104792 of 119592 relevant lines covered (87.62%)

1369037.09 hits per line