• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

dnsimple / dns_erlang / 19855295505

02 Dec 2025 10:24AM UTC coverage: 79.051% (-2.3%) from 81.309%
19855295505

push

github

web-flow
Cleanup chores (#85)

Copilot's explanation:
This PR performs cleanup and refactoring tasks in the DNS encoding and decoding modules. The changes extract duplicated code into helper functions, fix naming inconsistencies, correct a guard clause bug, and remove an unused macro.

- Extracts RSA and DSA key encoding/decoding logic into reusable helper functions
- Fixes function naming from do_decode_text to do_encode_text to accurately reflect its purpose
- Corrects a duplicate guard clause checking is_binary(MsgBin) twice instead of checking both MsgBin and DataBin

* Use better variable naming in dns_decode

* Name do_encode_text correctly

* Extract common code for dsa/rsa keys

* chore: remove unused macro

* Improve dnssec keytag types

* Fix coveralls parallel run

37 of 47 new or added lines in 2 files covered. (78.72%)

48 existing lines in 1 file now uncovered.

1283 of 1623 relevant lines covered (79.05%)

1234.98 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

77.23
/src/dns_encode.erl


Source Not Available

STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc