tari-project / tari / 19828569719
61%

DEFAULT BRANCH: development
Ran
Jobs 1
Files 706
Run time 2min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 60.819% (-0.08%) from 60.896%
19828569719

push

github

web-flow 
feat: add outputs to offline signing response (#7617)

Description
---

Adds `WalletOutput`s to the offline signing result.

Motivation and Context
---

The Payment Processor (specifically for
[coinjoin](https://github.com/tari-project/minotari_payment_processor/issues/2)
) requires the `WalletOutput` of the signed transaction to support
0-conf transaction creation.

How Has This Been Tested?
---

Updated unit tests to verify the correct number of outputs are returned.


<!-- Checklist -->
<!-- 1. Is the title of your PR in the form that would make nice release
notes? The title, excluding the conventional commit
tag, will be included exactly as is in the CHANGELOG, so please think
about it carefully. -->


Breaking Changes
---

- [x] None
- [ ] Requires data directory on base node to be deleted
- [ ] Requires hard fork
- [ ] Other - Please specify

<!-- Does this include a breaking change? If so, include this line as a
footer -->
<!-- BREAKING CHANGE: Description what the user should do, e.g. delete a
database, resync the chain -->


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

* **New Features**
  * Offline signing module version updated to 4.0.0
  * SignedTransaction now captures and includes transaction outputs
  * Signing workflows enhanced to preserve output data

* **Tests**
* Added comprehensive validation checks for transaction outputs across
signing scenarios

<sub>✏️ Tip: You can customize this high-level summary in your review
settings.</sub>

<!-- end of auto-generated comment: release notes by coderabbit.ai -->

14 of 14 new or added lines in 2 files covered. (100.0%)

2292 existing lines in 21 files now uncovered.

70665 of 116189 relevant lines covered (60.82%)

225737.29 hits per line

Uncovered Existing Lines

Lines Coverage ∆ File
1
98.88
 -1.12% base_layer/common_types/src/dammsum.rs
1
21.84
 -1.15% base_layer/core/src/chain_storage/error.rs
1
75.34
 -1.37% base_layer/node_components/src/blocks/chain_block.rs
1
82.99
 -0.35% comms/core/src/connection_manager/manager.rs
1
99.04
 -0.48% comms/dht/src/connectivity/test.rs
2
88.44
 -0.58% comms/core/src/multiplexing/yamux.rs
3
57.14
 -1.0% base_layer/core/src/base_node/sync/block_sync/synchronizer.rs
3
63.53
 0.0% comms/dht/src/connectivity/mod.rs
4
53.16
 3.16% base_layer/core/src/base_node/state_machine_service/states/listening.rs
5
52.98
 -0.16% base_layer/core/src/chain_storage/lmdb_db/lmdb_db.rs
17
0.0
 0.0% base_layer/wallet/src/transaction_service/protocols/transaction_broadcast_protocol.rs
36
35.99
 -0.34% base_layer/wallet/src/transaction_service/storage/models.rs
52
0.0
 0.0% base_layer/wallet/src/output_manager_service/storage/database/mod.rs
75
5.84
 -0.41% base_layer/common_types/src/transaction.rs
87
10.24
 -0.05% base_layer/wallet/src/output_manager_service/storage/sqlite_db/mod.rs
115
0.0
 0.0% base_layer/wallet/src/transaction_service/storage/database.rs
142
0.0
 0.0% base_layer/wallet/src/output_manager_service/handle.rs
214
0.0
 0.0% base_layer/wallet/src/transaction_service/handle.rs
416
40.29
 -0.6% base_layer/wallet/src/transaction_service/storage/sqlite_db.rs
543
0.0
 0.0% base_layer/wallet/src/output_manager_service/service.rs
573
0.0
 0.0% base_layer/wallet/src/transaction_service/service.rs
Jobs
ID Job ID Ran Files Coverage
1 19828569719.1 706
60.82
 GitHub Action Run
Source Files on build 19828569719