stacklok / toolhive / 19824339516

59%

Build Type

push

github

Committed by web-flow

Commit Message

Refactor/typed backend auth strategy (#2797)

* add auth/types package with typed strategy config structs

Create a new leaf package pkg/vmcp/auth/types containing:
- Strategy type constants (StrategyTypeUnauthenticated, etc.)
- BackendAuthStrategy struct with typed fields (HeaderInjection, TokenExchange)
- HeaderInjectionConfig and TokenExchangeConfig structs

The Metadata field is retained in BackendAuthStrategy for backward
compatibility - all existing code continues to work unchanged.

Update all files to import BackendAuthStrategy from auth/types instead
of config package. This is a structural refactoring with zero behavior
change, preparing for a follow-up PR that will remove the Metadata field.

* remove Metadata field and use typed auth config

Remove the deprecated Metadata map[string]any field from BackendAuthStrategy
and migrate all code to use typed fields (HeaderInjection, TokenExchange).

Key changes:
- Remove Metadata field from authtypes.BackendAuthStrategy
- Update Strategy interface to accept *BackendAuthStrategy instead of map
- Update all strategies (header_injection, tokenexchange, unauthenticated)
- Update converters to return typed BackendAuthStrategy
- Change Backend/BackendTarget structs to use AuthConfig instead of
  AuthStrategy + AuthMetadata
- Update ResolveForBackend to return *BackendAuthStrategy
- Update all consumers and tests

This provides type safety, better IDE support, and eliminates runtime
type assertions throughout the auth subsystem.

Run Details

169 of 209 new or added lines in 17 files covered. (80.86%)

6 existing lines in 3 files now uncovered.

25668 of 51327 relevant lines covered (50.01%)

60.06 hits per line