nunnatsa / ginkgolinter / 19817401025

88%

Build Type

push

github

Committed by nunnatsa

Commit Message

support for wrappers

Previously, linting was only done for function calls that the linter could
identify by name as being one of the methods in Gomega that are known to return
an Assertion or AsyncAssertion (Expect, Consistently, Eventually, etc.).

Now wrappers are also supported. The basic idea is that any function call which
returns any type that implements the Gomega assertion methods (To/Should, etc.)
can be treated as the root of a Gomega expression call chain.

Wrappers which take an offset as first parameter are not supported because
the linter isn't smart enough to detect that the first parameter is an offset.
Such wrappers should not be needed anymore thanks to ginkgo.Helper.

The "missing assertion" error then needs to be a bit more vague because it
cannot suggest what the appropriate assertion should be.

Run Details

186 of 218 new or added lines in 10 files covered. (85.32%)

14 existing lines in 4 files now uncovered.

2438 of 2789 relevant lines covered (87.41%)

1724.42 hits per line